Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSD8-1639: Uninstall and deprecate ECK #1545

Merged
merged 17 commits into from
Aug 2, 2024
Merged

HSD8-1639: Uninstall and deprecate ECK #1545

merged 17 commits into from
Aug 2, 2024

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Jun 4, 2024 •
edited
Loading

READY FOR REVIEW

Summary

Remove all remaining ECK configuration and code.
Remove the ECK dependencies from views.
Uninstall the ECK module.

Need Review By (Date)

['10/30', 'asap', etc.]

Urgency

['low', 'medium', 'high', etc.]

Steps to Test

  1. [First testing step]
  2. ...

PR Checklist

Base automatically changed from 11.0.1-release to develop June 26, 2024 17:27
@joegl joegl changed the base branch from develop to 11.1.2-release July 2, 2024 18:55
Base automatically changed from 11.1.2-release to develop July 10, 2024 16:23
@joegl joegl changed the base branch from develop to 11.1.4-release July 31, 2024 15:42
@joegl joegl requested a review from pookmish August 1, 2024 16:57
pookmish
pookmish reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the update it looks good. The majority of the files are in the configs inside the modules which doesn't impact existing sites.
I'll test it out locally later today when I have a few minutes.

@joegl
Copy link
Contributor Author

joegl commented Aug 1, 2024

Looking at the update it looks good. The majority of the files are in the configs inside the modules which doesn't impact existing sites. I'll test it out locally later today when I have a few minutes.

Yea the most important part is dropping the eck dependency from the views before uninstalling the module, otherwise the views would get deleted. The install configs would only affect new sites.

@joegl
Copy link
Contributor Author

joegl commented Aug 2, 2024

@pookmish Were you able to pull this down? I'd like to get it merged today if possible. Sorry for the short turnaround.

@pookmish
Copy link
Member

pookmish commented Aug 2, 2024

I'll try it now.

pookmish
pookmish approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joegl joegl changed the title HSD8-1639: ECK clean up HSD8-1639: Uninstall and deprecate ECK Aug 2, 2024
@joegl joegl merged commit f692327 into 11.1.4-release Aug 2, 2024
15 of 16 checks passed
@joegl joegl deleted the HSD8-1639--eck-clean-up branch August 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pookmish pookmish pookmish approved these changes

Assignees

@pookmish pookmish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joegl @pookmish